search

chris-ware / nova-breadcrumbs

Breadcrumbs for Laravel Nova
152 stars 44 forks source link

Ignore everything after question mark in url #112

Closed fathur closed 3 years ago

fathur commented 3 years ago

This PR is intended to support another package eminiarts/nova-tabs.

When using eminiarts/nova-tabs, it will generate URL like

/resources/some-resource/some-id?tab=SomeTab

Currently, this package will grab the whole last path some-id?tab=SomeTab, so the model cannot find the appropriate id because string after question mark included in the last path.

This PR remove everything after the question mark ?. Only some-id that will be returned. So the model can find the appropriate id.

chris-ware commented 3 years ago

@fathur I've implemented this a bit differently, using updated stringable mechanics to make this work which is much clearer.

fathur commented 3 years ago

when it will be released?

fathur commented 3 years ago

sorry my bad, this fixed in 2.1.0