chris-wood / draft-bar-cfrg-spake2plus

Other
5 stars 1 forks source link

Scott's review #14

Closed chris-wood closed 2 years ago

chris-wood commented 2 years ago

I went through the draft, the TLDR is that other than one sticking point (which has been raised before), it looks pretty good; my comments were about a few places which I thought could be expressed clearer.

Here are my comments (actually, I initially reviewed the -03 version and had more comments; some of those have already been addressed before I even raised them):

chris-wood commented 2 years ago

The only other issue (which has been raised a number of times before) is the selection of a global M for a specific parameter set. While this is convenient, this also means that the protocol has a 'solve one discrete log problem, break the entire system globally' property that I cannot endorse.

This is an interesting point. I think we can address this by saying that implementations MAY generate M and N that meet the requirements, provided we list the requirements (DLOG is not known). We do this for M and N out of alignment with the security analysis, so I think we ought to keep this the same and not use the identity element for N.

@ttaubert, what do you think?