search

chris-zen / coremidi

CoreMIDI library for Rust
https://chris-zen.github.io/coremidi/coremidi/
MIT License
75 stars 20 forks source link

Fix Undefined Behavior in Client and Properties #26

Closed jasongrlicky closed 4 years ago

jasongrlicky commented 4 years ago

Note that this pull request depends on https://github.com/chris-zen/coremidi/pull/22 and https://github.com/chris-zen/coremidi/pull/25

Fixes https://github.com/chris-zen/coremidi/issues/24, using the approach suggested there. This is not a breaking change in and of itself, but https://github.com/chris-zen/coremidi/pull/25, which it depends on, is.

Along the way:

chris-zen commented 4 years ago

Hi @jasongrlicky, the upgrade seems reasonable. Would you mind solving the conflicts with master so I can merge ?

jasongrlicky commented 4 years ago

Just rebased onto master to resolved the conflicts so it should be good to go now.

(Please let me know if that was not a great way to resolve that - I've been a solo dev for waaaay too long at this point, so I'm not very well versed in open source collaboration! 😅)