chris-zen / coremidi

CoreMIDI library for Rust
https://chris-zen.github.io/coremidi/coremidi/
MIT License
75 stars 20 forks source link

PacketBuffer rewrite #9

Closed Boddlnagg closed 7 years ago

Boddlnagg commented 7 years ago

This adresses the points discussed in #5. Details:

This PR also includes an upgrade to version 2.0 of coremidi-sys (the first two commits), getting rid of coremidi_sys_ext. If you want to have these as a seperate PR, I can do that, too.

Boddlnagg commented 7 years ago

The merge commit that you pushed introduced a failure. I force-pushed a rebased version with the fix (let's see if Travis agrees that it's correct 😉 ). And thanks for the review!

Boddlnagg commented 7 years ago

@chris-zen Thanks for the review! I will push a commit with the changes that you requested (is it okay if I just put them all in a single commit?). Actually, I am responsible for the 2.0 version of coremidi-sys, after looking at this library and talking to the developer of coremidi-sys 1.0, who happens to be a friend of mine 😉

Boddlnagg commented 7 years ago

I pushed a commit addressing the review comments

Boddlnagg commented 7 years ago

Thanks! Do you plan to release a new version soon? Then I will be able to update midir :-)

chris-zen commented 7 years ago

Done. Released 0.3.0