search

chris31415926535 / tardis

tardis: Text Analysis with Rules and Dictionaries for Inferring Sentiment
Other
2 stars 2 forks source link

CRAN version fails with dev stringr #1

Open hadley opened 1 year ago

hadley commented 1 year ago

Because str_detect(pattern = "") now errors. It works fine in the dev version because of the change in https://github.com/chris31415926535/tardis/commit/c15e0a75860c5f489c3b8359f618f565295b9bbf#diff-5f279892e5dcd7cb674cd0006c29f4cab3a26238d9e631d532926fe4281c66d6

chris31415926535 commented 1 year ago

Thanks for the heads-up!

hadley commented 1 year ago

FYI stringr is now scheduled for release to CRAN on Dec 2.

chris31415926535 commented 1 year ago

Thanks, I'm targeting a package update ~2 weeks before the string update for a smooth transition.