CakePHP 4 support - Githubissues

chris48s / cakephp-searchable

:cake: A CakePHP 3 behavior for creating MySQL MATCH() AGAINST() queries :mag:

https://packagist.org/packages/chris48s/cakephp-searchable

MIT License

4 stars 4 forks source link

CakePHP 4 support #4

Closed robertpustulka closed 2 years ago

robertpustulka commented 3 years ago

CakePHP 4+ compatibility updates.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 19

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 16:	0.0%
Covered Lines:	31
Relevant Lines:	31

💛 - Coveralls

chris48s commented 3 years ago

Hi @robertpustulka

Thanks for having a look at this.

I wrote a few CakePHP plugins a few years back, but since 2017 I don't use PHP in my job at all any more. This means I have not really kept pace with the latest developments in the PHP or CakePHP communities. I've had a look and the changes in this PR look sensible to me and all the tests pass, but I've never used CakePHP4 at all myself so I suspect if there was a small error I would not see it.

So here is my suggestion.. I notice you have made substantial contributions in the CakePHP ecosystem including to CakePHP core. If you are still relying on this library, I would be happy to either:

Give you push access to this repo and maintainer access to the package on packagist or
You can make a fork, push a new package to packagist and I'll mark https://packagist.org/packages/chris48s/cakephp-searchable abandoned in favour of your new package

This is a small module which not require much attention (I made the repo in 2016 and this is issue #4 🙂) and if you are actively using it you are better placed to keep it up to date than I am.

What do you think?

umer936 commented 3 years ago

Hi.

I've tried adding the plugin from @robertpustulka 's "cake-4" branch in my composer.json using the repository section and it seems to include, but I can't get it to find the Behaviors...

However, if either of the things @chris48s said happen, then I can remove all that and just include the package normally, which would be nice :)

umer936 commented 3 years ago

Here's composer.json to be able to use it:

    "repositories": [
        {
            "type": "package",
            "package": {
                "name": "chris48s/cakephp-searchable",
                "version": "2.0",
                "type": "package",
                "source": {
                    "url": "https://github.com/robertpustulka/cakephp-searchable.git",
                    "type": "git",
                    "reference": "cake-4"
                }
            }
        }
    ],

    "require": {
        "chris48s/cakephp-searchable": "^2.0"
    },

    "autoload": {
        "psr-4": {
            "Chris48s\\Searchable\\": "./vendor/chris48s/cakephp-searchable/src/"
        }
    },

    "extra":
    {
        "installer-paths":
        {
            "vendor/chris48s/cakephp-searchable": ["Chris48s/Searchable"]
        }
    },

and bootstrap()

        $this->addPlugin('Chris48s/Searchable',  [
            'path' => ROOT . DS . 'vendor' . DS . 'chris48s' . DS . 'cakephp-searchable' . DS . 'src'
        ]);

Not sure if all of these bits are correct, but it does finally work with all of these sections

robertpustulka commented 3 years ago

@chris48s Hi! Sorry for the late response. You can give me push access as a start, we'll see how it goes from here :). Thanks!

@umer936 Adding this to repositories should be enough:

        {
            "type": "vcs",
            "url": "https://github.com/robertpustulka/cakephp-searchable.git"
        }

My fix is tagged as 3.0:

"chris48s/cakephp-searchable": "^3.0"

CakePHP plugin installer will figure out the path itself. Just load a plugin as usual.

$this->addPlugin('Chris48s/Searchable');

chris48s commented 3 years ago

No problem :+1:

I've invited you to this repo. Once you accept the invite I'll make sure you have access to push and tag
The package is set to auto-update from github, so pushing a tag to the repo should also create a release on packagist but let me know your packagist username if there is an issue. I can add you as a maintainer on the package as well we need to
The next release should be 3.0.0 as dropping CakePHP 3 is a non-backwards-compatible change. I've pushed a commit to this branch starting a changelog entry: 405eb54
Feel free to merge and tag when you're ready

Thanks

wate commented 2 years ago

@robertpustulka

Would you like to be merged?

robertpustulka commented 2 years ago

@wate merged

I no longer use this package sorry. But the fix introduced here should work, at least it worked while I was using it.