load user supplied plugins

[chris48s]

Closes https://github.com/chris48s/v8r/issues/481 Closes https://github.com/chris48s/v8r/issues/483 Closes https://github.com/chris48s/v8r/issues/488

[socket-security[bot]]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/jsdoc-to-mdx@1.2.1	Transitive: environment, eval, filesystem, shell, unsafe	+109	22 MB	woodneck

🚮 Removed packages: npm/prism-react-renderer@2.3.1, npm/react-dom@18.3.1, npm/react@18.3.1

View full report↗︎

[socket-security[bot]]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source	CI
Potential typo squat	npm/ast-parser@0.2.0	Did you mean: arsts-parser (515 times more downloads)	docs/package-lock.json docs/package.json	🚫

View full report↗︎

Next steps

What is a typosquat?

Package name is similar to other popular packages and may not be the package you want.

Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore npm/ast-parser@0.2.0

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.29%. Comparing base (323148d) to head (acaea67). Report is 4 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #487 +/- ## ========================================== + Coverage 95.96% 96.29% +0.33% ========================================== Files 20 20 Lines 1139 1243 +104 Branches 260 266 +6 ========================================== + Hits 1093 1197 +104 Misses 45 45 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[chris48s]

OK. I think this is basically done.

Next steps are:

• https://github.com/chris48s/v8r/pull/487/commits/4431f7310afdfb484754acf0ca7ec8bb5b58fc4e implements the changes from https://github.com/chris48s/v8r/issues/488
  • Are you definitely 100% happy with the terminology now? Was the previous terminology actually better? Is there a secret third option?
  • Have you accounted for this in 100% of the places? Is there anything else that needs to change?
  • Once you push this release, this becomes public interface so any future changes are breaking
  • Naming things is hard :sob:
• Another round of self-review. Have another good look over all this with fresh eyes

Then I think you are good to :rocket:

[chris48s]

Another bit of nuance to document: How filename is resolved relative to cwd

[chris48s]

Another bit of inconsistency to clean up: filename and fileLocation for the same thing fileLocation is part of the JSON output format, so lets standardise on that.

[chris48s]

OK. I am FINALLY happy with the plugin interface. It is:

Input:

• registerInputFileParsers()
• parseInputFile(contents, fileLocation, parser)

Output:

• registerOutputFormats()
• getSingleResultLogMessage(result, fileLocation, format)
• getAllResultsLogMessage(results, format)

This has been such a vivid exercise in "naming things is hard"