Closed chris48s closed 3 weeks ago
I reckon also change the name of the 3rd argument to parseDocument()
from format
to parser
and update the docs accordingly
Hmm, but does parser imply it is the parser function itself. At least with format it is more clear this is a string like "toml" or "json".
You could always consider a breaking change to the config file/command line args to clean up the terminology there a bit.
Decisions decisions.
I ended up going with
registerInputFileParsers()
parseInputFile(contents, fileLocation, parser)
see https://github.com/chris48s/v8r/pull/487#discussion_r1713443398
Today in "naming things is hard"..
The term "format" is too overloaded, particularly given you refer to the output formats as just
--format
.Maybe change this to either
registerDocumentParsers
orregisterDocumentFormatParsers
Compare
to
I feel like the second is clearer.