chrisa / node-dtrace-provider

Native DTrace probes for node.js apps
Other
320 stars 68 forks source link

Fails to compile when path contains strange characters #103

Open simonexmachina opened 7 years ago

simonexmachina commented 7 years ago

dtrace-provider was not compiling for me with the version of Node installed by fnm. After some investigation I discovered that it's because fnm installs node to ~/.config/fnm/bin/node, and on my machine ~/.config is a symlink to ~/Dropbox (Personal)/home-dir/.config. When I moved this folder into ~, so it wasn't a symlink, the problem went away.

melloc commented 7 years ago

@aexmachina This seems to be a bug in node-gyp. The line here needs to quote everything that $(builddir) is used in so that the spaces don't become a problem. I'll file a bug against node-gyp, and see if there's any good way for the install scripts to work around it.

simonexmachina commented 7 years ago

Thanks @melloc