Closed chrisdoc closed 5 years ago
Hi @chrisdoc ,
There's no CI setup currently. I have a FreeBSD, SmartOS and OS X box that I currently run the tests on. I'll test these changes on them for you this week, and put the results here.
Thank you @melloc for your help in getting this tested
I tested the following combinations:
joyent_20180813T212436Z
), node v0.10.48, v0.12.16, v4.8.1, v6.17.0, and v8.15.1 (tested 32-bit and 64-bit for all versions)joyent_20190523T082605Z
), node v10.14.2 and v12.7.0 (64-bit)dtrace-provider
failed to compile with node v0.12.18 on macOS due to nodejs/nan#676, which I can't really do anything about in this library. That's probably fine, since I imagine most people are using newer node versions.
I also had to make some minor tweaks to get the tests running on macOS, due to what seems to be a regression in using -Z
to attach to USDT probes that haven't yet been defined. I'll follow up with a separate commit to update the tests to work once I'm convinced that's the problem, and that it's not something that libusdt should be updated to account.
Merged as 3cbb3c8. I'll prepare a 0.8.8 release once I figure out whether anything further needs to be done about the macOS issue.
Thank you @melloc
This PR aims to make
node-dtrace-provider
compatible with changes in v8 and allows the usage of the library with Node.JS 12. I ran the tests both for master with node10.15.2
and on the branch with node12.5.0
and on both I had 670 passing tests out of 699 total tests. I tested on MacOS 10.14.5 and disable SIP by executingcsrutil disable
in recovery mode. @chrisa do you have a continuous integration setup where I could test this PR.