search

chrisa / node-dtrace-provider

Native DTrace probes for node.js apps
Other
320 stars 68 forks source link

Fixes #74: deprecation warnings when used with node v6.0.0 #75

Closed jacargentina closed 7 years ago

jacargentina commented 8 years ago

Updates nan to 2.3.3

davepacheco commented 8 years ago

Based on the comments in #74, I don't think this is actually necessary, though it also seems reasonable.

ianvonholt commented 8 years ago

I get similar warnings with dtrace-provider and Node v6.2.0.

Forking and upgrading nan to the latest 2.3.3 fixed all warnings in OS X and Windows 10.

+1 on upgrading the nan dependency.

davepacheco commented 8 years ago

@ianvonholt I don't think there's anything wrong with doing that, but I don't think that will actually help anybody unless they reinstall. If they do reinstall, they'll already pick up 2.3.3 even without any changes to dtrace-provider's package.json.

ianvonholt commented 8 years ago

@davepacheco You are correct. It appears that some of my other packages where explicitly asking for nan 2.2.1 and the flat tree dependency resolution within npm was installing that. Sorry for the confusion!

blai commented 7 years ago

This is blocking the advancement to node 6 whenever you use some package like mcavage/node-ldapjs, which has a low level dependency on chrisa/node-dtrace-provider.

I also suggest we declare dependency to "nan": "2" (instead of 2.3.3)

davepacheco commented 7 years ago

Thanks. I went ahead and published version 0.7.0 with a fix for the case of higher-level dependencies (like the node-ldapjs case). See my note in #74 for details.