Closed No9 closed 7 years ago
Thanks! Do I understand correctly that this patch re-adds FreeBSD support for this module? Which versions are supported? What happens on other versions? Does it depend on libusdt#15 also?
Hey @davepacheco yes this patch re-adds FreeBSD support. I have tested it on FreeBSD 10.3 and FreeBSD 11 with https://github.com/chrisa/libusdt/pull/15 and it passes.
Thanks. If this depends on the newer libusdt, shouldn't it include a submodule update as well?
Hey @davepacheco Happy to reinclude the reference if that makes sense I took it out as it seemed to be conflicting with changes from @melloc and keeping the two in sync as other patches landed was a tad fustrating Let me know either way
@No9 Can you update the submodule to chrisa/libusdt@471ae4a? Also, can you include a comment explaining that FreeBSD's printf doesn't support %q?
Hi @melloc Added libusdt reference and updated the commit message as requested.
Merged as 942e227.
This patch reintroduces FreeBSD support for this library.
It updates the the build script to use
%s
instead of%q
the latter is not supported by default on FreeBSD.It requires that the base source for dtrace is installed on the build machine. This can be found in the standard
base.txz
for the release that being built on.It also removes the
malloc.h
include as that has been integrated intostdlib.h
outputs on FreeBSD 10.3 and 11