Fix chrisa/node-dtrace-provider#90 and integrate FreeBSD support

melloc commented 7 years ago

This will fix chrisa/node-dtrace-provider#90 and merge in the work to support FreeBSD that @No9 did.

melloc commented 7 years ago

I tested the following configurations:

Mac OS X (10.11.6) w/ node versions v0.10.47 (x86 & x64), v0.12.16 (x86 & x64), v4.6.0 (x64) and v7.5.0 (x64)
SmartOS w/ node versions v0.10.47 (x86 & x64), v0.12.16 (x86 & x64) and v4.7.3 (x86)
FreeBSD 10 w/ node version v6.9.1 (x64)

The newly added test fails against versions of dtrace-provider without the fix.

No9 commented 7 years ago

FreeBSD 11 w/ node version v6.9.1 is fine too

Should I PR an update to the docs to say that src is a prereq?

Maybe here https://github.com/chrisa/node-dtrace-provider#platform-support

..... FreeBSD is supported in principle but is restricted to only 4 working arguments per probe. To build you will also need the OS source code e.g. # curl http://ftp.freebsd.org/pub/FreeBSD/releases/amd64/11.0-RELEASE/src.txz > src.txz Then extract them into the default location # tar -C / -xvf src.txz .....

I'm also not 100% that the 4 arg limitation is still required but I will look at that separate to the original PR.

davepacheco commented 7 years ago

Thanks for the explanation. That all sounds great to me!

chrisa / node-dtrace-provider

Fix chrisa/node-dtrace-provider#90 and integrate FreeBSD support #94