chrisadolph / tile-simcf

R packages for visualizing statistical models, with tools for counterfactual simulation
faculty.washington.edu/cadolph/software
13 stars 10 forks source link

simcf Input Checks and Error Messages #8

Open chrisadolph opened 12 years ago

chrisadolph commented 12 years ago

simcf presently does little to check for acceptable inputs, and (mostly as a result) gives nonsensical error messages.

Checks need to happen at least in two ways: checks for cf objects, to make sure inputs are feasible for construction or editing of cf objects, and checks for inputs to simulation functions.

We never want to accidentally exclude inputs that would work, so if you're unsure if something is an error (just unwise), use warning() instead of error().

csjohns commented 12 years ago

For the record, this issue is being dealt with simultaneously with modularity, by building a new central simcf() which includes a range of input checks while converting inputs to cf objects to standardize process. Code to follow in a bit.