search

chrisakroyd / robots-txt-parser

A lightweight robots.txt parser for Node.js with support for wildcards, caching and promises.
MIT License
12 stars 8 forks source link

Update simple-get 2.4.0 to 4.0.1. #6

Closed Trott closed 2 years ago

Trott commented 2 years ago

This potentially fixes a security vulnerability in the dependency. The breaking changes from 2.4.0 to 4.0.1 involved adoption of ES6 and dropping support for EOL Node.js versions. Neither should be a problem here, I would expect.

Reference: https://github.com/advisories/GHSA-wpg7-2c88-r8xv

Trott commented 2 years ago

I suppose this repo is inactive.

chrisakroyd commented 2 years ago

Unfortunately GitHub had stopped sending me emails and notifications, I will check this out tomorrow but as all tests have passed it should be good to go. Thanks for this, and sorry for the delay.

Trott commented 2 years ago

Coverage change doesn't seem related, does it?

chrisakroyd commented 2 years ago

I can't work out what's caused the coverage dip, will spend some time figuring it out. Merged and published, thanks for the commit and it should be on npm as version 2.0.3.