search

chrisallenlane / cdash

A minimalist cryptocurrency portfolio dashboard for the command-line that draws market data from the Coin Market Cap API.
MIT License
14 stars 3 forks source link

Multi currency support #5

Closed donutloop closed 6 years ago

donutloop commented 6 years ago

Hi there, Currently, this tool views all prices in USD. Could we add support for other currency like EUR, what do you think about that idea?

I only see one tiny issue. How do we want to get the different currency symbols (€,$,...), any idea? Maybe we replace the symbol notation with a 3 letter notation (EUR, USD,...).

Best regards, Donutloop

chrisallenlane commented 6 years ago

@donutloop, +1. This was something I planned to implement when I had evidence that somebody other than me was using this thing :)

I've added a --base flag in v1.2.0 that implements this functionality: https://github.com/chrisallenlane/cdash/releases/tag/v1.2.0

There's still one nit to pick for another day: currently, , is always used as the thousands separator, and . is always used as the radix. I suspect that's incorrect for many of these added currencies. I'll sort that out some other time.

Closing as resolved. Thanks!

chrisallenlane commented 6 years ago

Actually, use 1.2.1:

https://github.com/chrisallenlane/cdash/releases/tag/v1.2.1

The prior contained a stupid whitespace issue that I didn't notice until after release.