search

chrisant996 / clink-flex-prompt

Flex prompt for Clink
MIT License
137 stars 17 forks source link

use `vcs_dirty` for dirty state #65

Closed gotoh closed 3 months ago

gotoh commented 3 months ago

I think vcs_dirty is a more appropriate color for the dirty state in hg_colors. https://github.com/chrisant996/clink-flex-prompt/blob/b5ec3c2ccb34051852c11fa2101c594e85c06954/flexprompt_modules.lua#L1154

chrisant996 commented 3 months ago

@gotoh Do you use mercurial?

The red color here comes from cmder-powerline-prompt/powerline_hg.lua (cmder-powerline-prompt was the starting point for the source control modules in clink-flex-prompt).

I don't use mercurial, and I didn't know if maybe red is considered appropriate by mercurial users. So I figured I would leave the color as red until/unless someone who actually uses mercurial indicates that the mercurial prompt should instead behave like the other source control prompts.

gotoh commented 3 months ago

Yes, I am (was) mercurial user on Windows. I attach a screen capture in command prompt. It shows 4 status (modified, added, removed, unknown). I suppose no reason that "red" is good fo "not clean" (dirty) state in hg. hg-cap-in-cmd

BTW, I'm using patched 'scm' module (not 'git' and 'hg' module) showing modification / unknown count with hg / svn like git. Attachced capture is an display example. I suppose it is better to use common color scheme for any vcs backend.

This is a capture in Cmder using hg and svn with flexprompt and patched 'scm' module. (note that color scheme is "Babun" and it is different to cmd.exe) scm-hg-svn-in-cmder

chrisant996 commented 3 months ago

Thanks for the confirmation and screen shots.

In what way is your scm module patched? Is the patch something that might be worth sharing?

gotoh commented 3 months ago

OK, I've made a PR #66. Please note that this patch is experimental and is very young. And I haven't given much thought to what kind of modification is appropriate in totaly regarding with hg module and svn module.

chrisant996 commented 3 months ago

Oh my. Thank you for sharing the PR. The problem is due to a typo bug -- see review comments in the PR for details.

chrisant996 commented 3 months ago

Fixed by commits: