search

chrisant996 / clink

Bash's powerful command line editing in cmd.exe
https://chrisant996.github.io/clink/
GNU General Public License v3.0
3.63k stars 143 forks source link

history delete doesn't work #452

Closed AndreKR closed 1 year ago

AndreKR commented 1 year ago

I was on Clink 1.4.22.something. I have a history items 1 to 136, as shown by history. I typed history delete 136 and if I remember correctly it showed something like "Deleted item 136". But a subsequent history would still show the item.

I then updated to Clink 1.4.23.5fc3fc. I now have a history with items 1 to 139. If I type history delete 136 now I get "Unable to delete history item 136.".

I now typed history clear and that worked.

chrisant996 commented 1 year ago

I can reproduce the same.

chrisant996 commented 1 year ago

It was broken for 25 months, since v1.1.43. Apparently history delete # isn't used very often.

codermonkey55 commented 1 year ago

@chrisant996 , I just ran into this myself; glad to see it has been fixed. Any estimates on when the new version with the fix will be published?

chrisant996 commented 1 year ago

It's been that way for 25 months, and there's a workaround, so it doesn't seem urgent. Clink v1.4.24 will be published in the next few days, when some other changes are ready.

chrisant996 commented 1 year ago

Oops, I successfully caught the COVID (first time; fully vaxxed, incl. bivalent booster).

I'm not going to publish a new version of Clink until after I'm better. There's no sense risking regressions due to brain fog, or risking inability to apply fixes in a timely manner if a regression were to occur.

codermonkey55 commented 1 year ago

It's been that way for 25 months, and there's a workaround, so it doesn't seem urgent. Clink v1.4.24 will be published in the next few days, when some other changes are ready.

What's the workaround?

chrisant996 commented 1 year ago

Oops. I mixed up two issues. 448 has a workaround. 452 does not.

I expect to publish v1.4.24 in a few days, after the worst of the COVID symptoms have passed. Interestingly, yesterday was the first day of symptoms and I was feeling bad last night, but by 6am my fever had broken and it seems I'm beginning to feel better. With any luck, maybe this will be a mild/short case.

codermonkey55 commented 1 year ago

No worries, like you said, it's not urgent. Regarding your COVID, hope that's truly the case and it's a mild/short case.

chrisant996 commented 1 year ago

I published v1.4.24.

My COVID continues to fade. So I decided I may as well publish the update. It seems I'm one of the lucky ones that has a super mild/fast response to this strain. No complaints here! My wife got hit hard for many days a few months ago, but we managed to isolate so it didn't spread to me. I've even been able to keep working full time (from home), and the impact is less than most colds. 🤷‍♂️ I attribute it to the vaccines/boosters, and to my generally strong immune system. Phew.

codermonkey55 commented 1 year ago

I attribute it to the vaccines/boosters, and to my generally strong immune system. Phew.

💪

codermonkey55 commented 1 year ago

Install release v1.4.24 and confirmed history delete is working, thank you.