chrisant996 / clink

Bash's powerful command line editing in cmd.exe
https://chrisant996.github.io/clink/
GNU General Public License v3.0
3.62k stars 143 forks source link

Wrong version indicated for updating. #528

Closed UweKeim closed 11 months ago

UweKeim commented 11 months ago

Just started a new terminal:

Microsoft Windows [Version 10.0.22621.2715]
(c) Microsoft Corporation. Alle Rechte vorbehalten.

Clink v1.5.16.51802d
Copyright (c) 2012-2018 Martin Ridgers
Portions Copyright (c) 2020-2023 Christopher Antos
https://github.com/chrisant996/clink

Clink v1.5.17 is available.
- To apply the update, run 'clink update'.
- To stop checking for updates, run 'clink set clink.autoupdate off'.
- To view the release notes, visit the Releases page:
  https://github.com/chrisant996/clink/releases

C:\Users\ukeim>

I had v1.5.16 and it told me, v1.5.17 is available.

In reality, v1.5.18 is available (and was installed afterwards).

Not that this bothers me in any way, I just wanted to document it here in case this is something others recognize, too.

chrisant996 commented 11 months ago

It was not "wrong":

At startup, Clink cannot do a network call to check for a new version -- that would introduce a noticeable delay.

Instead, Clink checks if it has an update already downloaded (in the background by a previous Clink session), and reports the version of whatever is already downloaded and ready to go.

But when applying an update, it makes a network call to make sure it gets the latest, in case there's a newer version than what is already downloaded.

So, what you experienced is possible and is intentional.

UweKeim commented 11 months ago

Thanks, Chris ❤️