search

chrisant996 / dirx

DIR eXtended for Windows
MIT License
22 stars 1 forks source link

Separate icon for empty folders similar to eza #4

Open eblis opened 7 months ago

eblis commented 7 months ago

Just noticed a very small difference between dirx and eza while comparing preview results for fzf after I just noticed you added --tree view 😄

EZA has a different icon for empty folders, whereas dirx has the same icon for all folders, empty or non-empty.

Not sure if you want to address this, it's quite a small issue but I thought I'd log it anyway. Notice the difference for tags folder.

Eza tree view: image

DirX tree view: image

chrisant996 commented 7 months ago

It's intentional that dirx doesn't.

That slows down eza. Especially when listing slow sources like network drives.

I can consider maybe adding some flag to opt into lower performance. Low priority for the future.

chrisant996 commented 7 months ago

We can leave this open for now. But there's a good chance it will never happen.

I'm opposed to incurring that amount of performance loss for a subtle cosmetic detail, especially since (1) the effort to optimize it to infer emptiness with help from other flags and states would be fairly large and (2) it gets confusing/ambiguous when a wildcard is used i.e. seeing a directory reported as having no files listed but having a non-empty icon (and eza currently just fails when given wildcards; which makes sense on *nix since shells handle wildcards, but on Windows apps handle wildcards but eza doesn't).

But that led me to notice that dirx --tree is not handling wildcards properly in subdirectories (only with --tree).

chrisant996 commented 7 months ago

v0.13 includes fixes for --tree with wildcards, --levels=1, among other things.

eblis commented 7 months ago

Wow, that was fast .. thanks !