Some Bugs in source code

chrisballinger / ProxyKit

SOCKS proxy server and socket client built upon GCDAsyncSocket.

MIT License

222 stars 59 forks source link

Some Bugs in source code #19

Open danleechina opened 6 years ago

danleechina commented 6 years ago

In the SOCKSProxySocket.m source file, when convert address (such as line 192) to NSString, the parameter length passed to initWithBytesNoCopy:length:encoding:freeWhenDone was wrong. It should use something like strlen(address) not INET_ADDRSTRLEN

liaogang commented 2 years ago

in socksConnect(), need convert the host to ipv4 address , if host is a ip