search

chrisbanes / gradle-mvn-push

Helper to upload Gradle Android Artifacts to Maven repositories
Apache License 2.0
1.05k stars 283 forks source link

Fixed issue #28 #29

Open ok3141 opened 10 years ago

ok3141 commented 10 years ago

I also added property POM_DEVELOPER_EMAIL and disabled failing build in case of javadoc errors appears.

cocoahero commented 10 years ago

Shouldn't it be android.sourceSets.main.java.sourceFiles, not android.sourceSets.main.java.source?

Plugin Source Reference: https://android.googlesource.com/platform/tools/base/+/gradle_0.11.1/build-system/gradle/src/main/groovy/com/android/build/gradle/internal/api/DefaultAndroidSourceDirectorySet.java

ok3141 commented 10 years ago

maybe :) but .source works for me

cocoahero commented 10 years ago

Strange that .source works. Unless I'm missing something obvious, that property doesn't exist. XD

ok3141 commented 10 years ago

please, correct my patch if I'm wrong. because I'm actually noob in groovy

cocoahero commented 10 years ago

You're not necessarily wrong, because you're right that it works. I'm just really confused as to why it works. I'm a total groovy noob as well, which is why I wouldn't be surprised if there is some magic somewhere that is adding that .source property.

cocoahero commented 10 years ago

Also, might be worth while adding in this patch as well, is the auto-linking to the Android documentation for referenced classes.

task androidJavadocs(type: Javadoc) {
    /* ... */
    options {
        linksOffline "http://d.android.com/reference", "${android.sdkDirectory}/docs/reference"
    }
    exclude '**/R.html', '**/R.*.html'
}
ok3141 commented 10 years ago

@cocoahero well, you was right. google-guys answered about the same thing: https://code.google.com/p/android/issues/detail?id=71174#c3

AlexanderLS commented 6 years ago

@ok3141 @cocoahero your commits merged to https://github.com/Vorlonsoft/GradleMavenPush