search

chrisbanes / insetter

Insetter is a library to help apps handle WindowInsets more easily
https://chrisbanes.github.io/insetter
Apache License 2.0
1.13k stars 42 forks source link

Add Migration.kt #114

Closed osipxd closed 2 years ago

osipxd commented 3 years ago

Closes #113

chrisbanes commented 3 years ago

Thanks 🙌

chrisbanes commented 3 years ago

Looks like there's some code style issues. Please run: ./gradlew spotlessApply apiDump and commit the changes.

osipxd commented 3 years ago

Hmm... I've added @Supress("unused") but looks like the compiler with the flag -Werror ignores it. Do you know any way to ignore warnings in this code?

chrisbanes commented 3 years ago

Hmm... I've added @Supress("unused") but looks like the compiler with the flag -Werror ignores it. Do you know any way to ignore warnings in this code?

The problem is that the params aren't used. @Suppress("unused") only suppresses the fact that function isn't used.

You can fix it by using @Suppress("unused", "UNUSED_PARAMETER") (I think)

osipxd commented 3 years ago

The problem is that the params aren't used. @Suppress("unused") only suppresses the fact that function isn't used.

You can fix it by using @Suppress("unused", "UNUSED_PARAMETER") (I think)

Yes, you're right, it works.\ I thought unused is some kind of super-class for UNUSED_PARAMETER and UNUSED_VARIABLE