chrisbanes / insetter

Insetter is a library to help apps handle WindowInsets more easily
https://chrisbanes.github.io/insetter
Apache License 2.0
1.13k stars 42 forks source link

Allo user to choose if he wants to consume insets wen using setOnApplyInsetsListener #89

Closed SamYStudiO closed 3 years ago

SamYStudiO commented 3 years ago

I had a case today, when i use setOnApplyInsetsListener on a container to do custom stuff, and then wanted to use applySystemWindowInsetsToMargin on a child view to have less boilerplater to apply simple insets, but of course this child view never got notified since insets were already consumed. I guess allowing user to chose if he wants to consume should be ok.

googlebot commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

SamYStudiO commented 3 years ago

@googlebot I signed it!

googlebot commented 3 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

SamYStudiO commented 3 years ago

I have a few lines adding extra tab that make build failed, any clue how to fix that?

chrisbanes commented 3 years ago

Code looks good. Just need to run ./gradlew spotlessApply to fix the code style

chrisbanes commented 3 years ago

Thanks!