search

chrisbarrett / skeletor.el

Powerful project skeletons for Emacs
GNU General Public License v3.0
126 stars 17 forks source link

Add embedded elisp evaluation per-template option #39

Open sergey-pashaev opened 5 years ago

sergey-pashaev commented 5 years ago

I ran into issue when I get Stack overflow in regexp matcher error when using big files (over 400kb in my templates). It happens inside skeletor--evaluate-elisp-exprs-in-string function. I've googled a little bit and it seems people usually solve this problem (which probably caused by emacs' regexp engine, details) by simplifying regexp, but I don't see ways to do it in this case. So I've added :no-eval-embedded-elisp? as per-template parameter to disable it for some specific projects. What are your thoughts on this issue?

p.s. Thanks for great project!

tendant commented 5 years ago

I have fixed the build issue in below commit.

https://github.com/tendant/skeletor.el/commit/05a1da98f7e8bb2bd77421886702be045878afe7

You can merge this change to your branch, or I can submit a new pull request.

sergey-pashaev commented 5 years ago

@tendant, I've merged your commit and Jenkins checks are ok now, thanks!