search

chrisbeluga / kirby-navigation

Navigation field for getkirby.com
78 stars 12 forks source link

4.0 Compatibility #40

Closed JerikoOne closed 1 week ago

JerikoOne commented 1 year ago

Currently the plugin is not compatible with 4.0 (as of writing this issue: Beta 1):

The API route isn't working image

The select isn't styled correctly

image
distantnative commented 11 months ago

@chrisbeluga To fix you could add the following styles

.navigation-field .k-dropdown-content {
  --button-height: auto;
}
afbora commented 11 months ago

@distantnative Unf, doesn't work.

afbora commented 11 months ago

Also getting alert for K4:

Deprecated: will be removed in a future version. Since Kirby 4.0, you don't need it anymore as wrapper element. Use <k-dropdown-content> as standalone instead. Deprecated: : align prop will be removed in a future version. Use the alignX prop instead. Deprecated: : the theme prop will be removed in a future version. For help text, add .k-help " CSS class instead.

cselex commented 10 months ago

Do we have a new forked maintained version?

afbora commented 10 months ago

Unf not yet.

lukas-dne commented 5 months ago

I managed to get it to work. Unfortunately I'm not that in into Vuejs and Kirbys plugin structure, so do not 100% understand, WHY it works - but does :D It seemes, that in Kirby 4 the plugin in the current state builds and adds the modal for adding pages to the menu correctly, but the overlay with this modal is not opened.

You have to add three lines of code, so the overlay with the desired overlay will open up:

File: site\plugins\kirby-navigation-main\src\Field.vue image

Perhaps someone with deeper understanding of Vuejs and Kirbys plugin system can explain, why this works? :)

To fix the dropdown menu, when clicking on "Add", you have to add the following:

File: site\plugins\kirby-navigation-main\src\Field.vue image

sachbearbeiter commented 4 months ago

What would have to be done for an "official" Kirby4 compatible version? Does anyone need a small bounty?

sachbearbeiter commented 3 weeks ago

FYI We have started to build a proper K4 version.

lukas-dne commented 3 weeks ago

Thats good news! :)

CoderofOne commented 3 weeks ago

@lukas-dne

What is needed after you add the lines of code? As the dialogs don't pop up for me.

chrisbeluga commented 3 weeks ago

Hey all,

Apologies that I haven't been around to support this plugin as much as I'd have liked.

I had started a full rewrite which isn't complete yet, I have shared the codebase with a couple of others who are interested in taking over. It's approx 90% complete with quid support etc.

If anyone else is interested then please let me know and I can share this and the new repo with you.

On Thu, 20 Jun 2024, 16:29 Sachbearbeiter, @.***> wrote:

What would have to be done for an "official" Kirby4 compatible version? Does anyone need a small bounty?

— Reply to this email directly, view it on GitHub https://github.com/chrisbeluga/kirby-navigation/issues/40#issuecomment-2180985423, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVE5J2RET5F4F3QF35C4NH3ZILYPLAVCNFSM6AAAAAA5DTVVMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBQHE4DKNBSGM . You are receiving this because you were mentioned.Message ID: @.***>

sachbearbeiter commented 2 weeks ago

We have opened a pull request. https://github.com/chrisbeluga/kirby-navigation/pull/41

lukas-dne commented 1 week ago

@CoderofOne Hi, I'm afraid I can not help you, because I did not fully understand the implementation. I was only a little bit lucky to get it working ;) But it seemes, that sachbearbeiter is actively working on the k4 ready version of the plugin. This would solve your problem, I suppose.

sachbearbeiter commented 1 week ago

There are some minor errors in our v4 version, but we will fix it in the next pull request.