search

chrisben / imgcache.js

JS library based on the File API to cache images for offline recovery (target: cordova/phonegap & chrome)
Other
826 stars 216 forks source link

⏲ add timeout option and set default to 30s #190

Closed gabrielstuff closed 7 years ago

gabrielstuff commented 7 years ago

Hi @chrisben ! This is a fix for #189

I hope you find it helpful.

Thanks,

G

chrisben commented 7 years ago

Thanks, I've added your changes to the latest 1.1.0 version (I didn't use your PR because I wanted to use another default value that doesn't break backward compatibility).

gabrielstuff commented 7 years ago

oh great ! It was a suggestion maybe the default timeout I putted is too short or maybe we should not have timeout by default. I enfonce to always have timeouts in our apps. Thanks again !