search

chrisbevan / skin.pellucid

A skin for Kodi by theDeadMan
Other
46 stars 43 forks source link

adding Heebo font support for Hebrew language #33

Closed arthurvaverko-kaltura closed 6 years ago

chrisbevan commented 6 years ago

Hi arthurvaverko, thanks for the PR. Unfortunately I cannot accept this work in its current form:

  1. None of the font weights are included.
  2. The skin is designed around the Roboto font. I do not wish to add additional font support.

Can you please tell me what language you wish to support / are not currently supported?

Thanks, Chris.

arthurvaverko-kaltura commented 6 years ago

Hebrew ... it looks fine with Arial .. can you tell me what you mean when you say font weights are not included ?

chrisbevan commented 6 years ago

Ah - OK. The Heebo font would make a better fit I think.

By font weight, I mean 'bold', light', 'black' etc. You've just replaced everything with regular Arial!

arthurvaverko-kaltura commented 6 years ago

done, and done .. :)