search

chrisbevan / skin.pellucid

A skin for Kodi by theDeadMan
Other
46 stars 43 forks source link

Photo library looks weird #8

Closed paulvt closed 8 years ago

paulvt commented 8 years ago

For the text is behind the thumbnails of a album (folder). The highlighted album/folder gets a white background and the label also turns white, making it unreadable.

chrisbevan commented 8 years ago

Thanks Paul. That section does need work. I'll get it fixed up ASAP.

On Thu, May 26, 2016 at 9:40 PM, Paul van Tilburg notifications@github.com wrote:

For the text is behind the thumbnails of a album (folder). The highlighted album/folder gets a white background and the label also turns white, making it unreadable.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/chrisbevan/skin.pellucid/issues/8

paulvt commented 8 years ago

Also I noticed that if I dive into albums/folders, the back buttons brings me to the side menu instead of one level up? I hope that the view can support this without me needing to enable the ".." items throughout the entire interface?

chrisbevan commented 8 years ago

Hmm. Yes, that should have been fixed up. Are you running the latest code?

On Fri, May 27, 2016 at 12:05 PM, Paul van Tilburg <notifications@github.com

wrote:

Also I noticed that if I dive into albums/folders, the back buttons brings me to the side menu instead of one level up? I hope that the view can support this without me needing to enable the ".." items throughout the entire interface?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chrisbevan/skin.pellucid/issues/8#issuecomment-222120113, or mute the thread https://github.com/notifications/unsubscribe/ADx8gG6RAQn8ui2DIXeLB__trPx3FEdiks5qFs_ygaJpZM4In7rL .

paulvt commented 8 years ago

Yes, I use git master (well, I pulled last Sunday).

chrisbevan commented 8 years ago

OK. Let me look into that. I know it works on my setup (Libreelec and OSX)

Expected behaviour of course is for the back button to only expose the side menu when there is no parent directory (only an issue for files, genres, artists etc). Like you, I have no desire to have the '..' folder items.

What's your setup?

paulvt commented 8 years ago

Kodi 16.1 on Linux; picture-wise it is several sources with nested folders containing albums in the leaves. I tried just now on my laptop too.. there I browse: Photos > 2015 > Holidays > [Some album]. If I press Backspace, I get the sidebar, not what's in "Holidays".

chrisbevan commented 8 years ago

No worries. I'll work on that (pic views have gotten waylaid somewhere - probably because I rarely use it). Can you confirm that the back button is working as expected within the music sections (genre, artist, etc)?

On Fri, May 27, 2016 at 7:55 PM, Paul van Tilburg notifications@github.com wrote:

Kodi 16.1 on Linux; picture-wise it is several sources with nested folders containing albums in the leaves. I tried just now on my laptop too.. there I browse: Photos > 2015 > Holidays > [Some album]. If I press Backspace, I get the sidebar, not what's in "Holidays".

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chrisbevan/skin.pellucid/issues/8#issuecomment-222226642, or mute the thread https://github.com/notifications/unsubscribe/ADx8gF3yWUaSoxDOXeUgQim8I41L_g8Cks5qFz4xgaJpZM4In7rL .

paulvt commented 8 years ago

Yeah, Videos/Music menu is fine. That's why I noticed it when I wanted to show pictures yesterday..

paulvt commented 8 years ago

Ah, the same thing happens when browsing Files in the Videos menu.

chrisbevan commented 8 years ago

Thanks. Should be fixed now.

God, visibility logic for Kodi's node system is such a ballache!

paulvt commented 8 years ago

Yes, works (both browsing Pictures and and browsing the Files section in Video and Music). Also the pictures library looks nice. :) Thanks!

chrisbevan commented 8 years ago

No problem!

BTW: I'll be moving on to Krypton updates shortly. With any luck, the changes to the skinning engine there will allow me to finally release the skin on the official repository and get back to updating Maximinimalism.

Thanks again for your support, it's hugely appreciated.

On Sat, Jun 4, 2016 at 9:01 PM, Paul van Tilburg notifications@github.com wrote:

Yes, works (both browsing Pictures and and browsing the Files section in Video and Music). Also the pictures library looks nice. :) Thanks!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chrisbevan/skin.pellucid/issues/8#issuecomment-223775308, or mute the thread https://github.com/notifications/unsubscribe/ADx8gG5YVVjyIoZMlrkmE25lwmq3Vk26ks5qIdmbgaJpZM4In7rL .