search

chrisblakley / Daylight-Calendar-ICS

Daylight Calendar is a dynamically generated .ics calendar that you can host and subscribe to in Google Calendar, iCal, or other calendar software.
https://gearside.com/google-daylight-calendar/
GNU General Public License v2.0
43 stars 6 forks source link

sun.php no longer displays sunrise times, only sunset #21

Open Ajedi32 opened 1 week ago

Ajedi32 commented 1 week ago

I recently noticed that sun.php is no longer showing sunrise times, only sunsets.

This regression seems to be caused by fcbe54989ce80de60f54db953f4ce3d527e9ba94 assigning identical UIDs for both the sunrise and sunset events.

chrisblakley commented 6 days ago

Thanks for bringing this to my attention– I will look into it as soon as I get a chance!

Ajedi32 commented 2 days ago

Did you just fix something on gearside.com? I don't see any new commits here, but sunrises are showing again, so thanks!

chrisblakley commented 2 days ago

Hey– yes I made a quick tweak this weekend but hadn't had a chance to test or document it so I hadn't replied yet– glad to hear it is working!

jackdfraser commented 1 day ago

Hi, I am also seeing the bug where it seems to be showing the inverse.

I'll attach some screen shots to clarify what I see.

Screenshot 2024-10-02 at 10 38 56 AM Screenshot 2024-10-02 at 10 40 11 AM
Ajedi32 commented 1 day ago

@jackdfraser That seems like a different bug, you might want to open another issue for that. It would also probably help if you shared the exact URL (i.e. the query parameters) you were using to get these results.

jackdfraser commented 1 day ago

@Ajedi32

fwiw: https://github.com/chrisblakley/Daylight-Calendar-ICS/issues/22