search

chrisblakley / Nebula

Nebula is a WordPress theme framework that focuses on enhancing development. The core features of Nebula make it a powerful tool for designing, developing, and analyzing WordPress websites consistently, yet its deliberately uncomplicated code syntax also serves as a learning resource for programmers themselves.
https://nebula.gearside.com
GNU General Public License v2.0
139 stars 36 forks source link

Fix missing argument error #2286

Closed pixelasticity closed 2 months ago

pixelasticity commented 2 months ago

I get an error from the set_cookie function due to a missing argument

Types of change(s)

Bug fix

What is the new behavior?

Doesn't change any behavior - only removes an error that can occur

chrisblakley commented 2 months ago

Thanks for this– what I may do to resolve this is set that third parameter to false by default at the function declaration itself so that this instance can be resolved, but also it can resolve any other similar instances.

So in /libs/Utilities/Utilities.php I've tried changing this:

public function set_cookie($name, $value, $expiration){

to this:

public function set_cookie($name, $value, $expiration=false){

Lemme know if that also works for you, and if not we can look into altering the individual function calls.

pixelasticity commented 2 months ago

That definitely works for me. Thanks for all your work on Nebula, it's great!

chrisblakley commented 2 months ago

Great– I will include this with the next commit this weekend– thanks again.