search

chrisbliss18 / php-ico

PHP ICO - The PHP ICO Generator
Other
222 stars 82 forks source link

Deprecated #18

Open ivose opened 1 year ago

ivose commented 1 year ago

Deprecated: Implicit conversion from float 146.574... to int loses precision in C:\xampp\htdocs\myproj\PHP_ICO.php on line 193 ($color |= 0xFF000000 & ( $alpha << 24 );). I've php version: PHP Version 8.2.0 . Possible solution: line 190 ought to be $alpha = intval((1 - ($alpha / 127)) * 255);.

jschwind commented 1 year ago

https://github.com/chrisbliss18/php-ico/pull/19/commits/9552d28a37c6b53164657f3fcdfd4e6a25760600

gtraxx commented 10 months ago

I made adaptations for PHP 8 and added fixes.

https://github.com/chrisbliss18/php-ico/pull/20