chrisboulton / php-diff

A comprehensive library for generating differences between two strings in multiple formats (unified, side by side HTML etc). Based on the difflib implementation in Python
725 stars 190 forks source link

ATTENTION! Don't use this package and any forks, use sebastian/diff instead #53

Open gugglegum opened 6 years ago

gugglegum commented 6 years ago

This package (chrisboulton/php-diff) is abandoned and not supported for several years. There's 167 other packages that forked from this root repo, but they are ugly. Most of them doesn't contain any changes. Many other contain questionable changes. A small number of forks contains 1-2 fixes or addition of some functionality necessary to authors. But all these forks are very low quality. Most of forks (as of original repo) doesn't use namespaces which makes difficulties if you want to use Composer's autoloader. There is a few repos that adds namespaces, but they seems to be abandoned too. They mostly are missing "Issues" section, so nobody can report a bug. Code quality is not good enough (at least for me). No unit-tests, no docs, no UTF-8 support. And all forks are crashes with count(): Parameter must be an array or an object that implements Countable when you making a diff for two arrays where one of them is empty. The error is in lib/Diff/SequenceMatcher.php in setSeq1() and setSeq2() (need replace if($a == $this->a) { to if($a === $this->a) {). This is very simple bug, but nobody found it and fixed.

I've tried these packages:

  1. chrisboulton/php-diff -- no namespaces, no multi-byte encodings
  2. phpspec/php-diff -- fixed some bugs, possible added multi-byte encodings, but still not namespaces, no Issues section
  3. adaptivemedia/php-text-difference -- added namespaces, but no Issues section, no Composer package, dev-stability
  4. JBlond/php-diff -- looks like supported, has Issues section, but no namespaces...

Then I found a better alternative of all this misunderstanding -- it's sebastian/diff (https://github.com/sebastianbergmann/diff). It works little different, but it has much better code quality, actively maintaining, supported and the author is an authority in PHP world (he maintain PHPUnit). Actually previously it was a part of PHPUnit but then was factored out. So I recommend to use his package instead and forget about chrisboulton/php-diff and all its forks.

JBlond commented 5 years ago

@gugglegum PRs are welcomed 👍 and yes I work on it as needed.

JBlond commented 5 years ago

@gugglegum JBlond/php-diff has now namespaces

jfcherng commented 5 years ago

I have my changes. https://github.com/jfcherng/php-diff

jfcherng commented 5 years ago

@JBlond I see you still develop php-diff recently. Maybe you would be interested in my repo above too.

fmonts commented 4 years ago

sebastian/diff doesn't seem to have colorized html output, and it shows the differences only as lines. It may be ok for code, but not for highlighting the differences in blocks of text, for example revisions of a blog post (if only a word in a sentence is changed, I want to see only that word highlighted). Anybody knows a better library to have something similar to diffchecker.com ?

Edit: jfcherng/php-diff works very well, thanks :)

JBlond commented 4 years ago

@fmonts check out JBlond/php-diff ,too