search

chrisboulton / php-resque

PHP port of resque (Workers and Queueing)
MIT License
3.43k stars 759 forks source link

Corrected type in Resque_Job::$payload docblock #246

Closed elazar closed 9 years ago

elazar commented 9 years ago

The docblock for the $payload property in the Resque_Job class is object, which is inconsistent with the array type used for the corresponding constructor parameter. Other usage of the $payload property, such as in updateStatus(), indicate that array seems to be correct.

danhunsaker commented 9 years ago

Is this the only DocBlock issue you've found so far? It would be nice to get all of them updated in one pass, if possible.

elazar commented 9 years ago

It is indeed the only one I've come across so far.

danhunsaker commented 9 years ago

Would you mind going through and looking for others? It would be really nice to have up-to-date documentation. :-)

elazar commented 9 years ago

Honestly, I only happened across this one while using the code for work. I could go through the rest, but I don't know how soon I'd be able to get to it. I have a lot of demands on my time at the moment. :(

danhunsaker commented 9 years ago

No worries. :-)

We're all in similar boats ourselves.

chrisboulton commented 9 years ago

Thanks! :+1: