search

chrisboulton / php-resque

PHP port of resque (Workers and Queueing)
MIT License
3.43k stars 759 forks source link

removed all closing PHP tags #287

Closed jesusch closed 8 years ago

jesusch commented 8 years ago

due to newline occurence in Jobs.php which causes problems using STDOUT

rajibahmed commented 8 years ago

:+1: it should default best practice, ending newline causes stupid problems.

danhunsaker commented 8 years ago

Only reason they were in there to begin with was support for older PHPs that required the closing tag... No longer a concern, I would think.

chrisboulton commented 8 years ago

Yup, there's no reason to have these lingering around - thanks!