search

chrisboulton / php-resque

PHP port of resque (Workers and Queueing)
MIT License
3.43k stars 759 forks source link

Use Matrix Exclude instead of hard-coded matrix #309

Closed danhunsaker closed 8 years ago

danhunsaker commented 8 years ago

While the current .travis.yml setup works, and the reasoning makes sense, it's far less readable than the previous configuration. This suggested patch presents an alternative approach to the same result, which uses the matrix->exclude array to filter out invalid tests, instead of hard-coding every valid combination as the current file does. This seems more readable, at least to me.

chrisboulton commented 8 years ago

Interesting - thanks.

Ignoring the failing build right now because that's my stupid with HHVM and the exceptions change I merged a few hours earlier, I'll address that.