search

chrisboyle / sgtpuzzles

Android port of Simon Tatham's Puzzles
https://chris.boyle.name/puzzles
Other
603 stars 168 forks source link

Margin changes with size #430

Open twinone opened 7 years ago

twinone commented 7 years ago

In grid games like Light Up, Loopy squares, etc. Having a 7x7 game has a slightly larger margin than playing a 14x14 game. Is there any specific reason for this behaviour or is it just a division error dividing the screen size by the grid size?

Wouldn't it be better if the grid took up the same space for a 7x7 game as for a 14x14 game, not wasting screen space, even though you end up with some grid cells being 31 pixels in width and others with 32?

chrisboyle commented 7 years ago

The games keep the tile size constant because it makes the tiles look consistent and makes the drawing code simpler and more maintainable. A better way to achieve a smaller margin, and solve #428 at the same time, would be to make coordinates floating-point throughout the codebase. That's a bigger job than I have time for right now though, and would certainly require coordination with Simon to push upstream, to ensure this port doesn't become a fork a million miles from his codebase that can't benefit from future improvements contributed to other platforms.