search

chrisboyle / sgtpuzzles

Android port of Simon Tatham's Puzzles
https://chris.boyle.name/puzzles
Other
603 stars 168 forks source link

Update README.md #434

Closed Poussinou closed 7 years ago

Poussinou commented 7 years ago

This small and useless PR improve the README.md and adds two buttons to get your app on F-Droid and Google Play Store ;)

Thanks for this app :)

chrisboyle commented 7 years ago

Thanks for your PR but unfortunately I must reject it. Mainly because it edits README which is Simon's upstream readme, where I already made my own README-android to avoid merge conflicts with his and to hold lots of Android-specific information. That android one could maybe be renamed README.md to show on github though.

Also, if, probably as a new PR, we do that rename and add links to Play Store and F-Droid, I am not willing to put F-Droid before Play until I have a way to make their builds fail-safe. By that I mean there has been one build already which omitted an important file such that users simply couldn't generate new games. There is lots of detail on #409 especially this comment https://github.com/chrisboyle/sgtpuzzles/issues/409#issuecomment-272881710 - basically I want to make it so they get either a complete working build or a build failure, and cannot ship something incomplete as they did, but I am limited by the Android build system, and have not yet found a way to achieve this.

For now though, I would accept a new PR that did the rename and linked to Play Store and then F-Droid in that order.

Poussinou commented 7 years ago

Hum, let's leave things as they are for now until you fix everything, these changes are minor.