search

chrisboyle / sgtpuzzles

Android port of Simon Tatham's Puzzles
https://chris.boyle.name/puzzles
Other
592 stars 167 forks source link

Any chance of the Altair grid type for Slitherlink/Loopy? #479

Open ER-95 opened 4 years ago

ER-95 commented 4 years ago

It consists of squares, pentagons, hexagons, heptagons, and octagons. image

mquevill commented 4 years ago

New grid types are usually added to the upstream repository. I have added new grid types before, and may work on this, since there is no grid type with heptagons yet! (Though my Compass Dodecagonal grid has been waiting for review for a while.)

ER-95 commented 4 years ago

@mquevill I would really appreciate it if that's possible! I've been looking for an "ultimate" version of Slitherlink for a long time now, and this has by far the most grid types - The only one it's missing is the one I've opened this ticket for, so adding it would be absolutely amazing.

ostrosablin commented 4 years ago

@mquevill Wow! I took a look at Compass Dodecagonal tiling and it's a really neat grid! Thanks for implementing it. Will recompile Loopy locally with your patch applied. Hope Simon will merge it into the upstream soon, so that it will be available on all platforms (including Android).

UPD: Did Simon acknowledge receiving the patch for it? From my experience talking to him over e-mail, sometimes messages to him seem to be lost in the inbox (he's a busy man, so I guess it happens sometimes). It's been over a year since the patch, so perhaps it's reasonable to re-send the patch for review?

ER-95 commented 4 years ago

@mquevill Just to follow on from @tmp6154's comment, did you happen to get a chance to look at implementing an Altair grid type? Many thanks

mquevill commented 4 years ago

The geometry of this puzzle is a lot more complicated than the other designs (excluding the Penrose tilings) currently in the game. The rules to generate a grid like this end up being quite complicated. The grids have to be on integers so most grids used ratios like 26 and 15 to emulate sqrt(3) to get the right geometry (or close). Since there are parts of this grid with sqrt(2) and sqrt(3) and a non-regular heptagon, it is difficult to define in a succinct way like most of the other grids are set up. I have a way that I want to try, but it depends on when I find time to do it.

ER-95 commented 4 years ago

@mquevill Would it help if I were to put some code together capable of generating the grids and popping it over to you? My issue doesn't lie with that so much as actually implementing it into the already existing code.

mquevill commented 4 years ago

@BenRobart That would be great, honestly. Adding in a new grid doesn't take that much adaptation, but in this case, the grid is more complicated than most other tilings.

I've opened an issue on my fork (https://github.com/mquevill/puzzles/issues/1) where we can further discuss this, but I am more than willing to accept any help you can provide. I will try to post any progress that I've made.

ostrosablin commented 3 years ago

On a side note, compass dodecagonal grid by @mquevill is finally accepted in upstream.