Added option to show keyboard on left side in landscape

chrisboyle / sgtpuzzles

Android port of Simon Tatham's Puzzles

https://chris.boyle.name/puzzles

Other

592 stars 167 forks source link

Added option to show keyboard on left side in landscape #483

Closed bwu62 closed 6 months ago

bwu62 commented 3 years ago

Follow up on #348

Added an option in settings menu to display keyboard on left side of game in landscape mode (unchecked by default). Briefly tested and seemed to work.

This is my first time editing/contributing to Android development. I did my best to model the contributed lines based on existing code. Please let me know if there's anything I can do better.

Thanks.

bwu62 commented 3 years ago

Sorry for the mess of commits. Tried to amend the commit message, but accidentally committed some IDE files in .idea, so I reverted those files and re-amend the commit.

bwu62 commented 3 years ago

Edited the option name in settings menu to improve clarity.

bwu62 commented 6 months ago

Seems like code has been majorly refactored and there's too many conflicts, I'll just close this pull request for now, readd in my changes later and then open another pull request.