search

chrisboyle / sgtpuzzles

Android port of Simon Tatham's Puzzles
https://chris.boyle.name/puzzles
Other
586 stars 167 forks source link

Integrate with "Dark theme" on Android 10+ #530

Closed chrisboyle closed 2 years ago

chrisboyle commented 2 years ago

We have a Night mode, which by default is activated based on light level, or can be forced on or off in app settings. Now the OS has a dark theme (dev guide), I think this would be another possible mode for the setting, so you have:

Night mode

Arguably this new mode could become the default for new installations, and I might be able to detect that the user has never changed the setting, in which case I could decide to apply it in that case too?

mquevill commented 2 years ago

Phrasing it as "Follow system settings" or "System default" would probably be more consistent with other apps.

I think it would be a good default setting, especially if you can migrate over whether users have/haven't changed that setting. It should be easy enough for the user to force it to whatever they want. (This app is one of the few I leave in light mode.)

chrisboyle commented 2 years ago

A quick experiment suggests the preference is written if you've ever opened the settings screen, even if you didn't touch night mode, i.e. there's no way to distinguish users who have changed the preference. :frowning_face: I'm therefore thinking of making "Follow system" the default for new installations only, but leaving any existing value alone (at the technical level: declare it as the default, but don't write any attempt at migration code).

Anyone who's ever opened the app in a low-light environment will know that night mode exists, and it's fairly prominent in the settings screen if they do want to change it. It'll also be mentioned in the "What's new" in Google Play. I think changing the preference out from under people would just unnecessarily annoy people who like the current behaviour, whether they explicitly chose it or not.