chrisboyle / sgtpuzzles

Android port of Simon Tatham's Puzzles
https://chris.boyle.name/puzzles
Other
586 stars 167 forks source link

Preference fixes and miscellaneous project cleanup #533

Closed TacoTheDank closed 2 years ago

TacoTheDank commented 2 years ago

Hello.

1st commit

2nd commit

3rd commit

4th commit

5h commit

6th commit

7th commit

chrisboyle commented 2 years ago

Thanks :-) I'm going to leave out the first two commits:

...but the rest looks good from a quick look, will review properly tomorrow.

chrisboyle commented 2 years ago

I've cherry-picked these commits into main with the above exceptions, thanks again

TacoTheDank commented 2 years ago

Thanks! That's fine :)

  • the second just because it's much easier for me to just update gradle myself in Android Studio than to actually review all those bash changes in a PR

I think you forgot to update the bash files. The command I ran in git bash was ./gradlew wrapper --gradle-version 7.4.2 --distribution-type bin --warning-mode all. You can check the integrity using https://gradle.org/release-checksums/