chrisboyle / sgtpuzzles

Android port of Simon Tatham's Puzzles
https://chris.boyle.name/puzzles
Other
584 stars 166 forks source link

Night mode broken on API 28 #585

Closed chrisboyle closed 1 year ago

chrisboyle commented 1 year ago

Describe the bug Reported by Win Bent and reproduced in emulator: on API 28, night mode colours are incorrect, e.g. the Solo cursor is black and the Galaxies lines are very faint.

To Reproduce Steps to reproduce the behavior:

  1. Use an API 28 device.
  2. Enable night mode.
  3. Launch Solo

Expected behavior Can see the grey cursor

Screenshots image

Additional context This happens because GameEngineImpl.getDefaultBackgroundColour() sees the night version of R.color.game_background despite the Context manipulation. :-( The backend then calculates other colours from the black colour and many things end up black.