search

chrisboyle / sgtpuzzles

Android port of Simon Tatham's Puzzles
https://chris.boyle.name/puzzles
Other
584 stars 166 forks source link

In night mode certain highlight features are invisible and icons are barely visible #586

Closed GamedevEmi closed 1 year ago

GamedevEmi commented 1 year ago

Describe the bug with night mode on, making highlights (such as selecting a square or using the note feature in undead and keen) are invisible against the dark background, previously they were gray (which was sufficiently visible). inputting values into a selected square shows the value correctly. In undead the monster icons show the outline but are filled in with the same color as the background, they are difficult to see

To Reproduce Steps to reproduce the behavior: (this example will use Undead, but I have also found the issue in Keen and Filling)

  1. Go to settings, turn on dark mode
  2. Open Undead (at this point the undead icons at the top are hollow outlines)
  3. Click any square to select it, click again to change to making notes (the lack of highlighting should be noticeable at this step)
  4. Enter a value
  5. See error

Expected behavior The highlighted square should be a different color from the others and the undead icons should be colored in instead of camoflaged into the background.

Screenshots Screenshot_20230119-164713_Puzzles

Version info (optional, but sometimes helpful)

Additional context In night mode, Black Box and Galaxies look different but i'm not certain that those are unintended changes. I used the term 'invisible' to describe the issue, but the highlights may be hidden behind the background.

chrisboyle commented 1 year ago

Hi, sorry, I just released a fix for this. You need a version starting 2023-01-18-... or newer.

(Duplicate of #585)