search

chrisboyle / sgtpuzzles

Android port of Simon Tatham's Puzzles
https://chris.boyle.name/puzzles
Other
584 stars 166 forks source link

don't reset zoom between games #589

Closed lrvideckis closed 1 year ago

lrvideckis commented 1 year ago

reason for change: I like to choose width, height and then zoom in a way to best utilize screen real estate. But currently, after starting a new game it resets zoom, and I have to re-zoom.

I play in a way where I finish a game every few minutes, so I have to re-zoom quite often.

This change keeps the zoom constant.

JonnyTech commented 1 year ago

IMO this should be an option in settings.

lrvideckis commented 1 year ago

Good point. Let me try to figure this out & update the PR in the next few days.

lrvideckis commented 1 year ago

Tested on my Pixel 6, by changing the setting and observing the zoom reset/not reset on various games

lrvideckis commented 1 year ago

I noticed a function onSharedPreferenceChanged in GamePlay.java. I'm pretty sure I don't need to do anything there