search

chrisboyle / sgtpuzzles

Android port of Simon Tatham's Puzzles
https://chris.boyle.name/puzzles
Other
584 stars 166 forks source link

Adding more games #596

Closed jjbali12 closed 4 months ago

jjbali12 commented 1 year ago

Hello Chris!

I cannot build the latest version of "Simon Tatham Puzzles", because i counter many errors. My plan is to add some "unreleased" games into that app, but i said that "i counter many errors", so can you build the app for me with many game? Also, i sent a mail from your account (johnnollas5@gmail.com)

jjbali12 commented 1 year ago

Can you add this games on your app?

sgt-puzzles-aho-extensions-main.zip sgtpuzzles-extended-master.zip puzzles-unreleased-master.zip

JupiLogy commented 1 year ago

Can you post the errors you're receiving?

chrisboyle commented 1 year ago

A few thoughts: firstly these appear to be downloads of the following github repositories. In this situation it's generally better to link to the repository rather than downloading and uploading a snapshot.

The good news is they all appear to keep the same MIT licence as upstream and this repo, so licensing does not prevent them being included.

The problem I have is that they're variously described as "unfinished", in which case I want to hear from their authors about what's unfinished (as well as reviewing the code myself), or having "not made it into the collection", suggesting Simon might have declined them for some reason, and if so I want to hear from their authors and/or Simon about why. I aim to keep the same high standards of quality and consistency in the Android port as Simon has for the original collection. Any games that meet those standards should probably be included in Simon's repo for all platforms, and then I'll pick them up from there.

jjbali12 commented 1 year ago

"CreateProcess error=2", it always appear even the git is correctly located.

On Mon, Mar 27, 2023, 7:37 PM JupiLogy @.***> wrote:

Can you post the errors you're receiving?

— Reply to this email directly, view it on GitHub https://github.com/chrisboyle/sgtpuzzles/issues/596#issuecomment-1484987311, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM76DNWB6XHTFBAMHKTRZMTW6F3WTANCNFSM6AAAAAAWIDHDZE . You are receiving this because you authored the thread.Message ID: @.***>

jjbali12 commented 1 year ago

Can you make a build and send the source code?

On Mon, Mar 27, 2023, 9:50 PM John bernard nollas < @.***> wrote:

"CreateProcess error=2", it always appear even the git is correctly located.

On Mon, Mar 27, 2023, 7:37 PM JupiLogy @.***> wrote:

Can you post the errors you're receiving?

— Reply to this email directly, view it on GitHub https://github.com/chrisboyle/sgtpuzzles/issues/596#issuecomment-1484987311, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM76DNWB6XHTFBAMHKTRZMTW6F3WTANCNFSM6AAAAAAWIDHDZE . You are receiving this because you authored the thread.Message ID: @.***>

SteffenBauer commented 1 year ago

The problem I have is that they're variously described as "unfinished", in which case I want to hear from their authors about what's unfinished (as well as reviewing the code myself), or having "not made it into the collection", suggesting Simon might have declined them for some reason, and if so I want to hear from their authors and/or Simon about why.

I am the author of one of those new game collections. I had mailed with Simon on various of those game extensions / new games. Simon's reasons to not include those were varied. For example he rejected the solving extensions of Solo (press a number to highlight the corresponding numbers / pencils marks in the grid, a feature that was asked for the android port several times in the issue tracker here) because he wanted to keep the puzzling experience minimalistic and clean. For the extended generator of Undead I didn't receive an answer. To be fair, Simon is very busy, and gets surely a lot of mail. So in the end, I just decided to put my game extensions to a GitHub repository so that other people can at least get the source code and compile them by themselves. For the puzzles 'creek', 'kropki' and 'walls', I didn't have a conversation with Simon so far at all, I don't know if he is even aware that these exists.

I created years ago even my own compiled Android app, including my new games and the games of X-Sheep, so it works principally. Unfortunately, with the big refactoring it would take too much new work to compile it again to an app, which I currently don't have.

In the end, I totally agree with Chris here. As the android app is among the device ports list on the official SGT puzzle page, it should include those puzzles that Simon deemed worthy to be included in his collection. I hope that Simon will find some time to look into these additional repositories, and include some new puzzles. In my personal opinion, there are definitely some that are of the quality that Simon expects (Boats from X-Sheep for example)

jjbali commented 1 year ago

where's the source code of your extension(s)?

On Mon, Mar 27, 2023, 10:22 PM Steffen Bauer @.***> wrote:

The problem I have is that they're variously described as "unfinished", in which case I want to hear from their authors about what's unfinished (as well as reviewing the code myself), or having "not made it into the collection", suggesting Simon might have declined them for some reason, and if so I want to hear from their authors and/or Simon about why.

I am the author of one of those new game collections. I had mailed with Simon on various of those game extensions / new games. Simon's reasons to not include those were varied. For example he rejected the solving extensions of Solo (press a number to highlight the corresponding numbers / pencils marks in the grid, a feature that was asked for the android port several times in the issue tracker here) because he wanted to keep the puzzling experience minimalistic and clean. For the extended generator of Undead I didn't receive an answer. To be fair, Simon is very busy, and gets surely a lot of mail. So in the end, I just decided to put my game extensions to a GitHub repository so that other people can at least get the source code and compile them by themselves.

I created years ago even my own compiled Android app, including my new games and the games of X-Sheep, so it works principally. Unfortunately, with the big refactoring it would take too much new work to compile it again to an app, which I currently don't have.

In the end, I totally agree with Chris here. As the android app is among the device ports list on the official SGT puzzle page, it should include those puzzles that Simon deemed worthy to be included in his collection. I hope that Simon will find some time to look into these additional repositories, and include some new puzzles. In my personal opinion, there are definitely some that are of the quality that Simon expects (Boats from X-Sheep for example)

— Reply to this email directly, view it on GitHub https://github.com/chrisboyle/sgtpuzzles/issues/596#issuecomment-1485203463, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3HPCMBBZM5UVCMSAALNZNTW6GPDPANCNFSM6AAAAAAWIDHDZE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

SteffenBauer commented 1 year ago

where's the source code of your extension(s)?

Well, among the links that Chris posted here in this thread? https://github.com/SteffenBauer/sgtpuzzles-extended

jjbali commented 1 year ago

I already downloaded it but i cannot compile the app because of the errors, what will be the version of android studio should i use?

On Mon, Mar 27, 2023, 10:30 PM Steffen Bauer @.***> wrote:

where's the source code of your extension(s)? Well, among the links that Chris posted here in this thread? https://github.com/SteffenBauer/sgtpuzzles-extended

— Reply to this email directly, view it on GitHub https://github.com/chrisboyle/sgtpuzzles/issues/596#issuecomment-1485219950, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3HPCMCGC3553ILVGF57YW3W6GP6RANCNFSM6AAAAAAWIDHDZE . You are receiving this because you commented.Message ID: @.***>

SteffenBauer commented 1 year ago

Those won't work with the current android port. It will take a lot of adjusting work.

jjbali commented 1 year ago

Ok, thanks for the reply.

On Mon, Mar 27, 2023, 10:35 PM Steffen Bauer @.***> wrote:

Those won't work with the current android port. It will take a lot of adjusting work.

— Reply to this email directly, view it on GitHub https://github.com/chrisboyle/sgtpuzzles/issues/596#issuecomment-1485228797, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3HPCMEWKVIL63KMVFDC7VLW6GQRNANCNFSM6AAAAAAWIDHDZE . You are receiving this because you commented.Message ID: @.***>

jjbali commented 1 year ago

Aside from that, what will be the version of android studio should i use to compile the app?

On Mon, Mar 27, 2023, 10:35 PM Steffen Bauer @.***> wrote:

Those won't work with the current android port. It will take a lot of adjusting work.

— Reply to this email directly, view it on GitHub https://github.com/chrisboyle/sgtpuzzles/issues/596#issuecomment-1485228797, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3HPCMEWKVIL63KMVFDC7VLW6GQRNANCNFSM6AAAAAAWIDHDZE . You are receiving this because you commented.Message ID: @.***>

SteffenBauer commented 1 year ago

A second remark on

suggesting Simon might have declined them for some reason, and if so I want to hear from their authors and/or Simon about why.

After buying an eReader (pocketbook brand), I took the time to port the puzzle collection to it. I contacted Simon and asked him if he could include a link to the port on the list of device ports on the official SGT puzzle site. Simon declined, exactly for the reason that I had included the unfinished puzzles (group and sokoban), and I assume also because I included the inofficial puzzles. So an official device port should really only include official puzzles, and one of the inofficial puzzles should only be added to the android port after having added to Simons official puzzle collection.

x-sheep commented 1 year ago

So an official device port should really only include official puzzles, and one of the inofficial puzzles should only be added to the android port after having added to Simons official puzzle collection.

This is also the reason I haven't included any of the unofficial puzzles in my UWP port.

Of my own collection, Ascent has to be my favorite. All of the puzzles except the ones I've listed under "Abandoned" are playable. In either case, I'm happy if Simon wants to add any of them to his collection, even without contacting me first. As said before, everything is MIT licensed, so asking me for permission isn't necessary.

goyalyashpal commented 1 year ago

at this point, it pretty much seems that there should be some "community" version of sgt puzzles lol.

similar to how there's manim community took by community from grant sanderson's personal manim

it will yield same benefits as in above case to sgt puzzles too:

goyalyashpal commented 1 year ago

i had one more idea for a game platform built upon the same idea as puzzles, when that is realised, that could also later become one separate arm of this sgt community puzzles...

otherwise, that would also hang of on its own... effectively starting from scratch in awareness and reach.

having a community thing would also help such new projects to get up to speed quickly, which have no scope in getting merged to sgt's upstream as they are entirely different thing from strict "puzzles"

goyalyashpal commented 1 year ago

searching for puzzles sgt on github, there are 28 repos in results, most of which are stale; there were some attempts of mirrors too - but even those have gone stale.

JupiLogy commented 1 year ago

Be the change you want to see in the world, and make a fork where you incorporate lots of community suggestions? Or, open issues on those existing forks. The branch might be stale but the developers may well be active.

chrisboyle commented 4 months ago

It seems like the discussion reached a conclusion without a convincing case for including more puzzles than Simon does, so I'm closing this, but best of luck with the various forks.