search

chrisboyle / sgtpuzzles

Android port of Simon Tatham's Puzzles
https://chris.boyle.name/puzzles
Other
584 stars 166 forks source link

Dark mode turns on even when setting is turned off #612

Open Johnathan-L-Gross opened 11 months ago

Johnathan-L-Gross commented 11 months ago

Describe the bug Dark mode with turn on at random times. Even when dark mode is turned off in settings, it will turn back on when starting a new puzzle.

To Reproduce Steps to reproduce the behavior:

  1. Start a new puzzle
  2. Dark mode turns on randomly

Steps to fix the behavior:

  1. Go to settings, dark mode is turned off
  2. Turn dark mode on
  3. Exit settings
  4. Return to settings
  5. Turn off dark mode
  6. Exit settings
  7. Dark mode is now off

Expected behavior Dark mode should not turn on if the setting is off.

Version info

Additional context Dark theme is turned on in phone settings

JupiLogy commented 11 months ago

Couldn't reproduce (on Android 12)

good luck

gricey432 commented 10 months ago

I'm experiencing this too

Version 2023-02-10-1537-bd5c0a37 Samsung galaxy A53 Android 13

mquevill commented 10 months ago

Just experienced this for the first time today as well. It happened after I had finished a game of Signpost. I generated a bunch of new games (through both the menu and finishing a game), but didn't get this issue any other time.

gricey432 commented 10 months ago

Just experienced this for the first time today as well. It happened after I had finished a game of Signpost. I generated a bunch of new games (through both the menu and finishing a game), but didn't get this issue any other time.

Interesting, I also had this on Signpost. I didn't include it in my comment because it's the only puzzle I'm playing right now so I didn't know it if was signpost specific...

mquevill commented 10 months ago

That's curious to know. So that's 2 data points for Signpost. @Johnathan-L-Gross, was your issue with Signpost or a different game? This would help to know the scope of this bug and what it is/isn't limited to.

doopl commented 10 months ago

I've had a similar issue but the other way round. I have Night Mode on in the app but a handful of times over the last few months a puzzle has generated in the light theme. I don't think it was in Signpost... probably Pearl and/or Bridges.

Same app version as others above, Android 11. My phone switches its system dark/light mode based on time of day.

Johnathan-L-Gross commented 9 months ago

That's curious to know. So that's 2 data points for Signpost. @Johnathan-L-Gross, was your issue with Signpost or a different game? This would help to know the scope of this bug and what it is/isn't limited to.

I'm mostly playing Loopy. I have experienced it on Signpost as well.

chrisboyle commented 8 months ago

That's curious to know. So that's 2 data points for Signpost. @Johnathan-L-Gross, was your issue with Signpost or a different game? This would help to know the scope of this bug and what it is/isn't limited to.

@mquevill I'd be quite surprised if it was related to what game you were playing; I'd expect it to be more related to what version of Android you have and maybe which manufacturer of phone / variant of Android

mquevill commented 8 months ago

That's curious to know. So that's 2 data points for Signpost. @Johnathan-L-Gross, was your issue with Signpost or a different game? This would help to know the scope of this bug and what it is/isn't limited to.

@mquevill I'd be quite surprised if it was related to what game you were playing; I'd expect it to be more related to what version of Android you have and maybe which manufacturer of phone / variant of Android

For data purposes, this was on a OnePlus 8T on Android 13 (OxygenOS 13.1). I have my phone in dark mode at the system level, but some apps are forced to be in light mode (including this one). The only app that normally gives me issues is Google Maps, where it will sometimes incorrectly switch into dark mode after switching to the app. Not sure if it's related to this at all.

nosblobs commented 5 months ago

I have seen this a lot too. I have dark mode on at android system level, but Puzzles in dark mode 'OFF', and it mostly happens in the evening when it's dark. Mostly play Loopy. Samsung phone android v14