chrisboyle / sgtpuzzles

Android port of Simon Tatham's Puzzles
https://chris.boyle.name/puzzles
Other
597 stars 168 forks source link

Use SVG (vector) icons directly #621

Open chrisboyle opened 11 months ago

chrisboyle commented 11 months ago

Now that minSdk is 21 to get Compose support, this also allows use of vector drawables for icons. Currently all of these button icons have been converted into PNGs in res/drawable-*dpi at 4 different sizes. Using SVGs directly would certainly be more maintainable, and might very slightly reduce the app size.

Note that the icons representing each game, as seen on the chooser, are generated from screenshots (in a similar way to upstream) so cannot benefit from this. The screenshots are of course generated by running the game with these save files and I could imagine generating SVGs instead, but the missing piece of that is an SVG-writing implementation of the Puzzles drawing API, and I'm not convinced it's worth creating one.