chrisboyle / sgtpuzzles

Android port of Simon Tatham's Puzzles
https://chris.boyle.name/puzzles
Other
584 stars 166 forks source link

Parts of screen cut off when in portrait mode at 2268*2440 resolution #652

Open agroberman opened 3 months ago

agroberman commented 3 months ago

Describe the bug On my OnePlus Open, unfolded in portrait mode, parts of many puzzles are cut off. Here are some screenshots:

Screenshot_2024-03-28-08-57-39-00_57594183e98acbd5c528e733d62aa74f Screenshot_2024-03-28-08-57-35-48_57594183e98acbd5c528e733d62aa74f Screenshot_2024-03-28-08-57-31-42_57594183e98acbd5c528e733d62aa74f Screenshot_2024-03-28-08-59-27-87_57594183e98acbd5c528e733d62aa74f Screenshot_2024-03-28-08-59-34-16_57594183e98acbd5c528e733d62aa74f

When in landscape, everything is fine:

Screenshot_2024-03-28-08-58-38-36_57594183e98acbd5c528e733d62aa74f

To Reproduce Steps to reproduce the behavior:

  1. Open app at the aforementioned resolution in portrait mode and launch magnets game
  2. Display is cut off at top

Expected behavior Display not cut off

Screenshots See above

Version info (optional, but sometimes helpful)

Additional context Thank you!

chrisboyle commented 1 month ago

@agroberman I just noticed the Full Screen option is on in your screenshots. Can you try turning it off? Might be related to #636 even though the symptoms are different

agroberman commented 1 month ago

Afraid the problem still occurs even with fullscreen disabled. Thanks for looking into this!

On Sat, Jun 1, 2024, 12:03 Chris Boyle @.***> wrote:

@agroberman https://github.com/agroberman I just noticed the Full Screen option is on in your screenshots. Can you try turning it off? Might be related to #636 https://github.com/chrisboyle/sgtpuzzles/issues/636 even though the symptoms are different

— Reply to this email directly, view it on GitHub https://github.com/chrisboyle/sgtpuzzles/issues/652#issuecomment-2143533565, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGXNTCJNWB32TG4LEF4FOODZFIEGLAVCNFSM6AAAAABFM6RFICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTGUZTGNJWGU . You are receiving this because you were mentioned.Message ID: @.***>

agroberman commented 1 month ago

I lied! After a restart of the app, the problem goes away while not in full screen mode (of course turning full screen back on again reintroduces the bug):

Thanks and good intuition!

On Sat, Jun 1, 2024, 13:16 Alexander Groberman @.***> wrote:

Afraid the problem still occurs even with fullscreen disabled. Thanks for looking into this!

On Sat, Jun 1, 2024, 12:03 Chris Boyle @.***> wrote:

@agroberman https://github.com/agroberman I just noticed the Full Screen option is on in your screenshots. Can you try turning it off? Might be related to #636 https://github.com/chrisboyle/sgtpuzzles/issues/636 even though the symptoms are different

— Reply to this email directly, view it on GitHub https://github.com/chrisboyle/sgtpuzzles/issues/652#issuecomment-2143533565, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGXNTCJNWB32TG4LEF4FOODZFIEGLAVCNFSM6AAAAABFM6RFICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTGUZTGNJWGU . You are receiving this because you were mentioned.Message ID: @.***>