chrisbra / Colorizer

color hex codes and color names
547 stars 30 forks source link

Splits and other windows don't get colorized #21

Closed moll closed 11 years ago

moll commented 11 years ago

After doing :ColorHighlight and :vs, for example, there's no color highlighting in the new window. Makes it hard to use when you constantly have multiple splits open and navigate to buffers inside them. Wouldn't it be possible to set the highlighting per buffer, not per buffer and window?

Cheers,

Andri

chrisbra commented 11 years ago

On Mon, July 29, 2013 13:12, Andri Möll wrote:

After doing :ColorHighlight and :vs, for example, there's no color highlighting in the new window. Makes it hard to use when you constantly have multiple splits open and navigate to buffers inside them. Wouldn't it be possible to set the highlighting per buffer, not per buffer and window?

Hi, does it help, to set let g:colorizer_auto_color = 1 in your .vimrc?

regards, Christian

moll commented 11 years ago

Thanks for the fast response — would you like me to do that to get you debug info? Otherwise I'd rather not automatically color all buffers.

chrisbra commented 11 years ago

On Mo, 29 Jul 2013, Andri Möll wrote:

Thanks for the fast response — would you like me to do that to get you debug info? Otherwise I'd rather not automatically color all buffers.

Are you setting g:colorizer_auto_filetype? If so, current head should fix it for you. So can you check, if current head works for you?

Grüße

Christian

Wer die Wahrheit hören will, den sollte man vorher fragen, ob er sie ertragen kann. -- Ernst R. Hauschka

moll commented 11 years ago

Hey! Nope, not setting any automatic coloring. I only invoke :ColorHighlight explicitly for the buffer I want and use more than one window to view that buffer in. Thanks for the potential fix. Will that work in the manual case as well?

chrisbra commented 11 years ago

Hi Andri!

On Mo, 29 Jul 2013, Andri Möll wrote:

Hey! Nope, not setting any automatic coloring. I only invoke :ColorHighlight explicitly for the buffer I want and use more than one window to view that buffer in. Thanks for the potential fix. Will that work in the manual case as well?

Just pushed an update, so should work as well.

Christian

Die Absurdität der religiösen Dogmen macht es zu einer endlosen Aufgabe, gegen sie polemisieren zu wollen. -- Arnulf Øverland

moll commented 11 years ago

Thanks, I can confirm that it seems to work.

However, I now spotted, it's rather slow to enter a window when highlighting is turned on. That might've been a problem previously, too, but in any case, it's quite noticeable for me (around 300ms–500ms). Is this something you see too and would you like me to open another issue for that?

chrisbra commented 11 years ago

On Mo, 29 Jul 2013, Andri Möll wrote:

Thanks, I can confirm that it seems to work.

However, I now spotted, it's rather slow to enter a window when highlighting is turned on. That might've been a problem previously, too, but in any case, it's quite noticeable for me (around 300ms-500ms). Is this something you see too and would you like me to open another issue for that?

Does it still happen? It is tricky, to make it color correctly and at the same time have the user not notice the lag. What Vim version are you using?

regards,

Christian

Nur Narren wollen gefallen; der Starke will seine Gedanken geltend machen. -- Heinrich Heine

moll commented 11 years ago

I'm on MacVim 7.4 Snapshot 67. I'll give it a try in a couple of days, but you don't notice anything, I'm assuming?

How does the thing work? If you're merely re-entering a window there shouldn't be any color processing overhead, should there?